[webkit-reviews] review granted: [Bug 26001] Change callers of String::adopt() to String::createUninitialized() : [Attachment 30660] Fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Moore <davemoore at google.com>'s
request for review:
Bug 26001: Change callers of String::adopt() to String::createUninitialized()
https://bugs.webkit.org/show_bug.cgi?id=26001

Attachment 30660: Fix
https://bugs.webkit.org/attachment.cgi?id=30660&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 44135)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,31 @@
> +2009-05-25  David Moore  <davemoore at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).

There's no comment here. Need to cite the bug number and URL and say what
you're doing and why. Event better is to have a per-function comment explaining
what was done to each function.

> +	   int dataLength = data.length();

Should be unsigned.

r=me