[webkit-reviews] review granted: [Bug 25969] REGRESSION (r42334): Unnecessary scroll bars remain after the document shrinks : [Attachment 30670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 26 09:04:44 PDT 2009

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 25969: REGRESSION (r42334): Unnecessary scroll bars remain after the
document shrinks

Attachment 30670: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   Added two tests in fast/dynamic.

It's better to give the names of the tests.

> -- (void)_boundsChanged
> +- (void)_boundsChangedToNewSize:(NSSize)size

I think _boundsChangedTo: would be fine here rather than

> -    if (!NSEqualSizes(_private->lastLayoutSize, [self bounds].size)) {
> +	if (!NSEqualSizes(_private->lastLayoutSize, size)) {

Indented one extra space here.

> -	       frame->view()->resize([self bounds].size.width, [self
> +	       frame->view()->resize(size.width, size.height);

How about just resize(IntSize(size)) here instead? Has to be an explicit
conversion because it's a conversion from floating point to integer, but nice
to leave it as an object instead of breaking up into width/height.

> +- (void)setFrameSize:(NSSize)size
> +{
> +    [self _boundsChangedToNewSize:size];
> +    [super setFrameSize:size];
> +}

I'm not sure we need a separate _boundsChangedToNewSize: method. I'd just put
that code into the setFrameSize: override and not have a separate method.


More information about the webkit-reviews mailing list