[webkit-reviews] review denied: [Bug 26016] HTMLOptionElement::ownerSelectElement() needs to consider keygen : [Attachment 30663] fix bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 26 07:36:01 PDT 2009


Darin Adler <darin at apple.com> has denied Grace Kloba <klobag at gmail.com>'s
request for review:
Bug 26016: HTMLOptionElement::ownerSelectElement() needs to consider keygen
https://bugs.webkit.org/show_bug.cgi?id=26016

Attachment 30663: fix bug
https://bugs.webkit.org/attachment.cgi?id=30663&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Fix looks fine. Please add a regression test.

Since ownerSelectElement is used in accessKeyAction, index, and setSelected
there are multiple ways you could test this simply in a regression test.


More information about the webkit-reviews mailing list