[webkit-reviews] review denied: [Bug 24758] [Gtk] Implement a WebDataSource for the gtk port : [Attachment 29264] implement data source API in webkitwebframe

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 29264: implement data source API in webkitwebframe
https://bugs.webkit.org/attachment.cgi?id=29264&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> Index: WebKit/WebKit/gtk/tests/testwebdatasource.c

I think you should add the tests to the other patch. They look good to me, but
will need to be adapted after the API changes are done.

> +//	 g_test_add("/webkit/webdatasource/get_text_encoding_name",
> +//		    WebDataSourceFixture, 0, web_data_source_fixture_setup,
> +//		    test_webkit_web_data_source_get_text_encoding_name,
web_data_source_fixture_teardown);

?

> +WebKitWebDataSource*
webkit_web_frame_get_provisional_data_source(WebKitWebFrame* frame)

Hmm. Why would anyone want the provisional data source? Isn't it just a blank
thing?

> Index: WebKit/WebKit/gtk/ChangeLog
> ===================================================================
> --- WebKit.orig/WebKit/gtk/ChangeLog	2009-04-05 15:13:18.000000000 +1000
> +++ WebKit/WebKit/gtk/ChangeLog	2009-04-05 15:16:12.000000000 +1000

This part of the patch looks like something wrong happened hehe.