[webkit-reviews] review requested: [Bug 26006] Sort out lexical / dynamic global object for window.location : [Attachment 30657] patch with lexicalFrame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 25 12:10:41 PDT 2009


Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26006: Sort out lexical / dynamic global object for window.location
https://bugs.webkit.org/show_bug.cgi?id=26006

Attachment 30657: patch with lexicalFrame
https://bugs.webkit.org/attachment.cgi?id=30657&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I changed the JSC code to lexicalFrame and left the V8 code with callingFrame. 
That way the variables match the terminology for each bindings.  (This patch is
still compiling, but I can fix any typos before landing.)


More information about the webkit-reviews mailing list