[webkit-reviews] review requested: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 30632] add new source input and filterBuilder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 24 12:30:51 PDT 2009


Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 30632: add new source input and filterBuilder
https://bugs.webkit.org/attachment.cgi?id=30632&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
I talked with Nikolas on IRC. I hope I address all of the problems Eric and
Nikolas mentioned.
FilterBuilder has two hashmaps. One for the standard inputs and one for the
custom filter effects with a name. This avoids creating new strings on every
call of getFilterEffect().


More information about the webkit-reviews mailing list