[webkit-reviews] review denied: [Bug 23477] Support for WCSS extensions : [Attachment 27392] Patch :: -wap-accesskey support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 23 17:28:50 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Rohini Ananth
<rohini.ananth at nokia.com>'s request for review:
Bug 23477: Support for WCSS extensions
https://bugs.webkit.org/show_bug.cgi?id=23477

Attachment 27392: Patch :: -wap-accesskey support
https://bugs.webkit.org/attachment.cgi?id=27392&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
For the WAP marquee properties, I suggested using a separate .in file for the
property names like SVG does. I think that would be good here. At the very
least the names should be conditional with ifdefs.

The change in accessKeyModifiers is not explained and seems unrelated. If it is
related, please explain it in the ChangeLog.

r- to address these two issues.


More information about the webkit-reviews mailing list