[webkit-reviews] review granted: [Bug 21492] [Cairo] Synthetic Bold/Oblique not working with cairo : [Attachment 24329] patch for synthetic font support with cairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 23 13:17:51 PDT 2009


Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 21492: [Cairo] Synthetic Bold/Oblique not working with cairo
https://bugs.webkit.org/show_bug.cgi?id=21492

Attachment 24329: patch for synthetic font support with cairo
https://bugs.webkit.org/attachment.cgi?id=24329&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if(font->platformData().syntheticOblique()) {

Need a space after the "if" here.

Everything else looks OK, although the technique of drawing the text twice
isn't the best known synthetic bold technique.

r=me


More information about the webkit-reviews mailing list