[webkit-reviews] review denied: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 30608] add new source input and filterBuilder

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 19991: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Attachment 30608: add new source input and filterBuilder
https://bugs.webkit.org/attachment.cgi?id=30608&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
There are tabs in this file:
 42		m_lastEffect = effect.get();
 43 
 44		if(!id.isEmpty())
 45		    m_namedEffects.set(id.impl(), effect.get()); 


This seems wrong, memory management wise:
 45		    m_namedEffects.set(id.impl(), effect.get()); 


You shouldn't be calling effect.get() the second time I dont' think.  Or you
shouldn't be passing it in as a PassRefPtr.  You're never taking ownership?  or
at least the code doesn't look like it.

Otherwise looks fine.  r- for the memory issue.