[webkit-reviews] review granted: [Bug 25823] [Qt] Add API to generate a QUrl from a user string url : [Attachment 30387] the patch with the api

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 21:49:44 PDT 2009

Holger Freyther <zecke at selfish.org> has granted Benjamin Meyer
<ben at meyerhome.net>'s request for review:
Bug 25823: [Qt] Add API to generate a QUrl from a user string url

Attachment 30387: the patch with the api

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +    If that is not the case, an attempt is made to turn the string into a
> +    http:// or ftp:// URL. The latter in the case the string starts with
> +    'ftp'. The result is then passed through QUrl's tolerant parser, and
> +    in the case or success, a valid QUrl is returned, orelse a QUrl().

orelse??? space missing?

> +	   QUrl url = view->guessUrlFromString(string);

my taste would say to use the static type QWebView::guessUrlFromString...
ignore that at your will..

are you sure that QWebView is the best place for that? If I have a QWebPage in
a graphics view item I still want to use the guessing and using QWebView might
not feel right. Do you think QWebView is the best place to put it? what about

More information about the webkit-reviews mailing list