[webkit-reviews] review denied: [Bug 25934] [Qt] Add a setting attribute to disable/enable WebCore memory cache. : [Attachment 30544] add AlwaysEnableObjectCache setting attribute, to avoid changing the behavior of setObjectCacheCapacities.

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 25934: [Qt] Add a setting attribute to disable/enable WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=25934

Attachment 30544: add AlwaysEnableObjectCache setting attribute, to avoid
changing the behavior of setObjectCacheCapacities.
https://bugs.webkit.org/attachment.cgi?id=30544&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
r=- because of two/three things:
  1.) Missing documentation. You will need to document the enum
  2.) Look at the name of the enum. OfflineStorageDatabaseEnabled (Enabled at
the end) and compare to this attribute. It should be consistent but I suck with
names :)
  3.) WebCore::cache() is a singleton, you make it look like something you can
set locally (per QWebPage...) but it is not. I think this should be modeled
with a static function..


> @@ -568,6 +573,7 @@ int QWebSettings::maximumPagesInCache()
>  void QWebSettings::setObjectCacheCapacities(int cacheMinDeadCapacity, int
cacheMaxDead, int totalCapacity)
>  {
>      bool disableCache = cacheMinDeadCapacity == 0 && cacheMaxDead == 0 &&
totalCapacity == 0;
> +
>      WebCore::cache()->setDisabled(disableCache);
>  
>      WebCore::cache()->setCapacities(qMax(0, cacheMinDeadCapacity),

bogus whitespace.