[webkit-reviews] review denied: [Bug 20073] Pending resource requests not always stopped when new request is loaded : [Attachment 22331] Possible patch which needs careful review by somebody experienced with the loader.

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 20073: Pending resource requests not always stopped when new request is
loaded
https://bugs.webkit.org/show_bug.cgi?id=20073

Attachment 22331: Possible patch which needs careful review by somebody
experienced with the loader.
https://bugs.webkit.org/attachment.cgi?id=22331&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r- for the following:

1) The comment is too long.
2) No ChangeLog entry.
3) No test case.
4) After review of the code, I am not sure if true or false is right. The
difference is that stopLoading(true) will send an unload event, while false
will not. The best way to check which is right is to check if other browsers
send an unload even in this situation.

Conceptually, it seems right to stop loading here, just these details need to
be worked out.