[webkit-reviews] review granted: [Bug 25709] Skia/Cairo image decoders should be merged : [Attachment 30587] part two

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 19:31:21 PDT 2009


Eric Seidel <eric at webkit.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 25709: Skia/Cairo image decoders should be merged
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 30587: part two
https://bugs.webkit.org/attachment.cgi?id=30587&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
style:
 407	     unsigned data_size = num * sizeof(unsigned);
Maybe that's matching the style of the file?
style:
void PNGImageDecoder::decodingFailed() {
 225	 m_failed = true;

Looks fantastic.


More information about the webkit-reviews mailing list