[webkit-reviews] review granted: [Bug 25971] Some Video Elements Creeping Into Non-Video Builds : [Attachment 30598] Correct a few build errors.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 17:47:21 PDT 2009
Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 25971: Some Video Elements Creeping Into Non-Video Builds
https://bugs.webkit.org/show_bug.cgi?id=25971
Attachment 30598: Correct a few build errors.
https://bugs.webkit.org/attachment.cgi?id=30598&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebCore/rendering/RenderThemeWin.cpp (working copy)
> @@ -28,7 +28,9 @@
> #include "HTMLElement.h"
> #include "HTMLSelectElement.h"
> #include "Icon.h"
> +#if ENABLE(VIDEO)
> #include "RenderMediaControls.h"
> +#endif
> #include "RenderSlider.h"
> #include "Settings.h"
> #include "SoftLinking.h"
Please move conditional includes into their own paragraphs below unconditional
includes before landing.
r=me
More information about the webkit-reviews
mailing list