[webkit-reviews] review granted: [Bug 15914] [GTK] Implement Unicode functionality using GLib : [Attachment 26793] 1/4 - Moving WTF Unicode backend to GLib (v2)

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 15914: [GTK] Implement Unicode functionality using GLib
https://bugs.webkit.org/show_bug.cgi?id=15914

Attachment 26793: 1/4 - Moving WTF Unicode backend to GLib (v2)
https://bugs.webkit.org/attachment.cgi?id=26793&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   https://bugs.webkit.org/show_bug.cgi?id=15914
> +	   [GTK] Implement Unicode functionality using GLib

I have gone through all the comments now, and have verified that most comments
have been addressed. I think the best way to move forward is to land the patch
in its current state, before it gets old enough that too much has changed, now
that you have made it smaller and self-contained. I have given it another pass,
and found only indentation problems, which I fixed (see UnicodeGLib.h for
reference, so that you can get it right for the next patches), and two missing
function implementations (including the one found by Mikkel), which I added. I
also fixed header inclusion on top of UnicodeGLib.h.

I have tested that the ICU backend keeps working, and passing tests. This,
along with the facts that icu keeps being the default, and that your patch
touches little cross platform code makes me believe that we're ready for
landing it now.