[webkit-reviews] review denied: [Bug 25944] Remove the uses of V8 Locker in worker execution code. : [Attachment 30553] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 07:06:52 PDT 2009

Eric Seidel <eric at webkit.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 25944: Remove the uses of V8 Locker in worker execution code.

Attachment 30553: Proposed Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your ChangeLog needs explanation as to why this change is correct and

Is this possible to test?  If so it needs a test case. If not, then the
ChangeLog needs and explanation of why it's not possible to test, and possibly
a link to a bug requesting additional features in our testing framework.  Since
it's not possible to run DumpRenderTree with V8 such a bug would be against
test_shell in the Chromium tree.

Thanks for the patch!  Dimitri is probably your best reviewer for actual
content however.  Above was mostly just me applying standard patch review
policy. :)

More information about the webkit-reviews mailing list