[webkit-reviews] review denied: [Bug 25711] HTML5 Database becomes locked if a transaction is in progress when the page is refreshed. : [Attachment 30483] Proposed fix and layout test

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ben Murdoch <benm at google.com>'s
request for review:
Bug 25711: HTML5 Database becomes locked if a transaction is in progress when
the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=25711

Attachment 30483: Proposed fix and layout test
https://bugs.webkit.org/attachment.cgi?id=30483&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Mostly style violations:
http://webkit.org/coding/coding-style.html

 622 int Database::busyHandler(void* p, int n) {
bad argument names, { goes on a new line

no { } needed:
4     while (n--) {
 625	     millis += 1.2*millis;
 626	 }
although we've been inconsistend w/ whiles.

Also spacing between 1.2 and millis (Which should be a full name, like
milliseconds)

We use constants instead of defines where possible:
 55 #define MAX_SQLITE_BUSY_WAIT_TIME 30000

Variable names:
 122	 static int busyHandler(void* p, int n);

Tabs in the layout tests.

Otherwise this looks fine in general, but really you shoudl have Bradee look at
it for content once style is fixed.