[webkit-reviews] review denied: [Bug 23296] add Android platform-specific files to WebCore/platform : [Attachment 30004] new patch part 8 with ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 06:48:28 PDT 2009
Eric Seidel <eric at webkit.org> has denied Feng Qian <feng at chromium.org>'s
request for review:
Bug 23296: add Android platform-specific files to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=23296
Attachment 30004: new patch part 8 with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=30004&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm surprised we have any time code in WebCore? Isn't that all down in WTF?
Why does andriod need its own different ICU code? TextBoundaries.cpp?
IntRect() is the same as 54 return IntRect(0, 0, 0, 0);
Isn't there an easier way to get the FrameView than your manual crawl?
r- for the nits and questions.
More information about the webkit-reviews
mailing list