[webkit-reviews] review granted: [Bug 25500] Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056 : [Attachment 29930] Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 01:09:49 PDT 2009
Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25500: Remove Range::compareBoundaryPoints(Position, Position) per Darin's
suggestion in bug 25056
https://bugs.webkit.org/show_bug.cgi?id=25500
Attachment 29930: Remove Range::compareBoundaryPoints(Position, Position) per
Darin's suggestion in bug 25056
https://bugs.webkit.org/attachment.cgi?id=29930&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Mostly looks ok. But please remove this function if it's not actually used.
Would rather not add dead code.
+int comparePositions(const VisiblePosition& a, const VisiblePosition& b)
+{
+ return comparePositions(a.deepEquivalent(), b.deepEquivalent());
+}
+
More information about the webkit-reviews
mailing list