[webkit-reviews] review denied: [Bug 25809] decorations __declspec(dlimport) and __declspec(dlexport) break linking on win32 with mingw : [Attachment 30379] A proper standard-compliant patch with ChangeLog entries

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 25809: decorations __declspec(dlimport) and __declspec(dlexport) break
linking on win32 with mingw
https://bugs.webkit.org/show_bug.cgi?id=25809

Attachment 30379: A proper standard-compliant patch with ChangeLog entries
https://bugs.webkit.org/attachment.cgi?id=30379&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Are the decorations MSVC-specific, or do they fail only in GCC? Would it be
better to use COMPILER(MSVC) instead of !COMPILER(GCC)? (Honestly not sure; r-
for reply to question but feel free to just reflag this patch if the way it is
now is right.)