[webkit-reviews] review denied: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 27296] Alternate patch to issue 20534

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Glenn Wilson
<gwilson at google.com>'s request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 27296: Alternate patch to issue 20534
https://bugs.webkit.org/attachment.cgi?id=27296&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
One minor comment:

+- (void)setPreference:(NSString *)key stringValue:(NSString *)value

Private ObjC methods on API classes should start with an underscore.

Otherwise looks good, assuming it doesn't break the tests now. Please resubmit
with that minor change.