[webkit-reviews] review granted: [Bug 25771] Webkit fails to load plugins if the embed tag within the object tag is specified without a mime type. : [Attachment 30305] Proposed patch for this issue.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 21:20:20 PDT 2009


Eric Seidel <eric at webkit.org> has granted Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 25771: Webkit fails to load plugins if the embed tag within the object tag
is specified without a mime type.
https://bugs.webkit.org/show_bug.cgi?id=25771

Attachment 30305: Proposed patch for this issue.
https://bugs.webkit.org/attachment.cgi?id=30305&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good to me.  I've re-written the test case as a test case in
fast/replaced/ (because there is a resources/test.swf there).

<object type="application/x-oleobject"
classid="CLSID:D27CDB6E-AE6D-11CF-96B8-444553540000">
    <param name='movie' value='resources/test.swf'></param>
    <embed src='resources/test.swf'></embed>
</object> 

We really need a better test swf file.	This one, although hysterical, isn't
really the best simple test case. :)

Looks sane to me.  I'll test and land this.


More information about the webkit-reviews mailing list