[webkit-reviews] review denied: [Bug 23296] add Android platform-specific files to WebCore/platform : [Attachment 29998] new patch part 3 with ChangeLog

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Feng Qian <feng at chromium.org>'s
request for review:
Bug 23296: add Android platform-specific files to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=23296

Attachment 29998: new patch part 3 with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=29998&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Style violation:
     if (handle != -1) {
 63	    return filename;
 64	}

No need to have filename outside of the while block.  Just put the if inside
the while block. :)

I suggest breaking the filename generation stuff out into its own function.

temporaryFileName(name, number)

Doesn't write deal with size_t instead of int?

Sorry this took so long. I don't get any notification when you set a requestee.
 I suggest not setting a requestee on patches you post.