[webkit-reviews] review granted: [Bug 23430] Frame Refactor: Move methods from Frame to Editor : [Attachment 26862] Do the moving

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 18:32:56 PDT 2009

Eric Seidel <eric at webkit.org> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 23430: Frame Refactor: Move methods from Frame to Editor

Attachment 26862: Do the moving

------- Additional Comments from Eric Seidel <eric at webkit.org>
So long as you're just moving code, this looks great.  I worry that this patch
is long-since rotten (that the methods you're moving may have changed).

It seems a little strange that selectedText() is on Editor instead of say
SelectionController, but it seems fine.

r=me, if you make sure the patch is updated to compile with TOT with all the
LayoutTests passing and that you're certain that the code you are moving is

More information about the webkit-reviews mailing list