[webkit-reviews] review granted: [Bug 25860] Chromium Linux font fallback should try more fonts : [Attachment 30566] align with switch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 17:03:19 PDT 2009


Eric Seidel <eric at webkit.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 25860: Chromium Linux font fallback should try more fonts
https://bugs.webkit.org/show_bug.cgi?id=25860

Attachment 30566: align with switch
https://bugs.webkit.org/attachment.cgi?id=30566&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great.  Dave could add an ASSERT(fontPlatformData); right before the
return.  In that case, where a user's system is totally hosed, we might as well
crash early instead of late.


More information about the webkit-reviews mailing list