[webkit-reviews] review granted: [Bug 25946] Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation. : [Attachment 30555] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 14:11:38 PDT 2009

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension

Attachment 30555: Proposed fix.

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Looking at MediaPlayer.cpp, it really doesn't matter what we do here.  In fact,
the cost of getMIMETypeForExtension might not even be worth it.  MediaPlayer
only calls this function to take a guess at the mime type, which it then uses
to help select the media player engine.  Chromium only has one engine, so the
guessed mime type is not interesting to us.

R=me with either the current solution or just returning String() <-- i'd
probably just return String().

More information about the webkit-reviews mailing list