[webkit-reviews] review granted: [Bug 25890] Implement Network logging channel on Mac : [Attachment 30509] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 10:35:57 PDT 2009

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 25890: Implement Network logging channel on Mac

Attachment 30509: proposed patch

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>-- (void)connection:(NSURLConnection *)unusedConnection
didFailWithError:(NSError *)error
>+- (void)connection:(NSURLConnection *)connection didFailWithError:(NSError
> {
>-    UNUSED_PARAM(unusedConnection);
>+    UNUSED_PARAM(connection);
>+    LOG(Network, "Handle %p delegate connection:%p didFailWithError:%@",
m_handle, connection, error);

Is NSError* converted to an NSString* implicitly here?


More information about the webkit-reviews mailing list