[webkit-reviews] review requested: [Bug 24696] Enable mixed content detection : [Attachment 30522] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 20 23:06:28 PDT 2009


Adam Barth <abarth at webkit.org> has asked  for review:
Bug 24696: Enable mixed content detection
https://bugs.webkit.org/show_bug.cgi?id=24696

Attachment 30522: patch v2
https://bugs.webkit.org/attachment.cgi?id=30522&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Here is a second attempt.  ap and I discussed this patch on #webkit.  He
thought it might be better to use the willSendRequest to do the mixed content
check on the theory that the client should be making these policy decisions. 
fishd thought this approach was better because checking the mixed content
policy in willSendRequest adds a synchronous IPC message to the browser process
in chromium, which affects performance.

There seems to be some amount of precedence for adding security context
information to ResourceRequests.  For example, we already have the
mainDocumentURL (which is actually very quirky).


More information about the webkit-reviews mailing list