[webkit-reviews] review granted: [Bug 19357] [GTK] Loading of resource images : [Attachment 30181] Another implementation of resource loading

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 20 10:20:36 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 19357: [GTK] Loading of resource images
https://bugs.webkit.org/show_bug.cgi?id=19357

Attachment 30181: Another implementation of resource loading
https://bugs.webkit.org/attachment.cgi?id=30181&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
(In reply to comment #16)
> > I would say r=me if those issues (indentation and no SVG) are fixed, or if
> > there's a rationale for not being able to support SVG in this specific
> > instance.
> 
> the no SVG has one practical issue. we are not able to load it. We will
return
> a byte array here and we have no way to load that through any kind of svg
> renderer. So in the case of an all svg theme it is best to use our internal
> icon...
 
r=me, then, with the other fixes; thanks for clarifying!


More information about the webkit-reviews mailing list