[webkit-reviews] review granted: [Bug 21546] [GTK] ATK accessibility enhancements : [Attachment 30510] focussignals.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 21546: [GTK] ATK accessibility enhancements
https://bugs.webkit.org/show_bug.cgi?id=21546

Attachment 30510: focussignals.patch
https://bugs.webkit.org/attachment.cgi?id=30510&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> @@ -110,6 +113,9 @@ namespace WebCore {
>      inline void AXObjectCache::selectedChildrenChanged(RenderObject*) { }
>      inline void AXObjectCache::postNotification(RenderObject*, const
String&) { }
>      inline void AXObjectCache::postNotificationToElement(RenderObject*,
const String&) { }
> +#if PLATFORM(GTK)
> +    inline void handleFocusedUIElementChangedWithRenderers(RenderObject*,
RenderObject*) { }
> +#endif
>  #endif

You're missing AXObjectCache:: here. I believe that won't build with
ACCESSIBILITY disabled, but then again, is it even possible to build with no
accessibility for GTK+? I think we don't need to provide that empty
implementation at all. Otherwise good.