[webkit-reviews] review granted: [Bug 25414] [GTK] ROLE_PANEL should not be used for paragraphs and list items. : [Attachment 30506] listitemrole.patch

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25414: [GTK] ROLE_PANEL should not be used for paragraphs and list items.
https://bugs.webkit.org/show_bug.cgi?id=25414

Attachment 30506: listitemrole.patch
https://bugs.webkit.org/attachment.cgi?id=30506&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +    // WebCore does not seem to have a role for list items
> +    if (AXObject->roleValue() == GroupRole) {

isGroup()

> +	   AccessibilityObject* parent = AXObject->parentObjectUnignored();
> +	   if (parent && parent->roleValue() == ListRole)

isList()

With those changes, r=me.