[webkit-reviews] review denied: [Bug 10930] WebKit could benefit from a JavaScript live object profiler : [Attachment 29915] Adds live object profiling capabilities

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Horia Olaru <olaru at adobe.com>'s
request for review:
Bug 10930: WebKit could benefit from a JavaScript live object profiler
https://bugs.webkit.org/show_bug.cgi?id=10930

Attachment 29915: Adds live object profiling capabilities
https://bugs.webkit.org/attachment.cgi?id=29915&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The most obvious issue with this patch is that the change to JSCell::operator
new is likely to butcher performance whether the profiler is enabled or not --
have you tested perf in sunspider with the profiler disabled?

Additionally i think it would be best if the api added a different method to
profiler object creation as most frequently people wish to profile execution
time rather than object overhead, yet this is likely to add significant time
and memory pressure that will skew those results in that case.