[webkit-reviews] review denied: [Bug 25864] strict aliasing issues in WebCore/page/SecurityOriginHash.h : [Attachment 30472] attempted fix for strict aliasing issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 22:45:08 PDT 2009


Eric Seidel <eric at webkit.org> has denied Craig Schlenter
<craig.schlenter at gmail.com>'s request for review:
Bug 25864: strict aliasing issues in WebCore/page/SecurityOriginHash.h
https://bugs.webkit.org/show_bug.cgi?id=25864

Attachment 30472: attempted fix for strict aliasing issue
https://bugs.webkit.org/attachment.cgi?id=30472&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
bug 16317 is another way to make this code cleaner.  But given the above
comments, I think we should close this and someone who is interested in turning
on strict aliasing warnings for WebCore can do this for real later.


More information about the webkit-reviews mailing list