[webkit-reviews] review denied: [Bug 25869] Upstream V8 bindings for V8DomWindow. : [Attachment 30485] patch2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Nate Chapin
<japhet at google.com>'s request for review:
Bug 25869: Upstream V8 bindings for V8DomWindow.
https://bugs.webkit.org/show_bug.cgi?id=25869

Attachment 30485: patch2
https://bugs.webkit.org/attachment.cgi?id=30485&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Darn it! One more round of laundering :-\

> +	       V8Proxy::ThrowError(V8Proxy::GENERAL_ERROR, "Cannot decode
base64");
> +	       return v8::Undefined();

One more! Use throwError helper from V8Proxy.h

> +    if (args.Length() < 1) {
> +	   V8Proxy::ThrowError(V8Proxy::SYNTAX_ERROR, "Not enough arguments");
> +	   return v8::Undefined();
> +    }

Same here.

> +    if (args.Length() < 1) {
> +	   V8Proxy::ThrowError(V8Proxy::SYNTAX_ERROR, "Not enough arguments");
> +	   return v8::Undefined();
> +    }

And here.

> +    String str = ToWebCoreString(args[0]);

toWebCoreString

> +    return Base64Convert(str, true);

Whoops. Functions should be camelCase. How did I miss this earlier?
convertBase64?