[webkit-reviews] review denied: [Bug 23287] Avoid using FontPlatformData outside the FontCache : [Attachment 26662] Step 1: Make getCachedFontPlatformData private and export an equivalent method that return a SimpleFontData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 20:42:26 PDT 2009


Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 23287: Avoid using FontPlatformData outside the FontCache
https://bugs.webkit.org/show_bug.cgi?id=23287

Attachment 26662: Step 1: Make getCachedFontPlatformData private and export an
equivalent method that return a SimpleFontData
https://bugs.webkit.org/attachment.cgi?id=26662&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the code will be easier to review if we skip this intermediary step and
just make FontPlatformData private to begin with.  Right now you're adding
extra code in CSSFontFaceSource which just makes this patch more confusing.


More information about the webkit-reviews mailing list