[webkit-reviews] review denied: [Bug 23642] [GTK] Drag and drop support : [Attachment 28123] The drag clipboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 18:34:26 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 23642: [GTK] Drag and drop support

Attachment 28123: The drag clipboard

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +    if (image())
> +	   deleteDragImage(image());
> +    setImage(0);

This seems to be wrong indeed. You would at least need to implement the
function for GTK+. I believe the best course of action is changing this,

    typedef void* DragImageRef;

I think you should turn this into:

typedef GOwnPtr<GdkPixbuf*> DragImageRef;

Then you would not need the deleteDragImage implementation and call at all. I
believe these changes could be part of this patch, since the drag clipboard
implementation doesn't touch other code, it wouldn't matter in terms of
bisecting. Sounds good?

More information about the webkit-reviews mailing list