[webkit-reviews] review denied: [Bug 25858] Upstream V8 bindings for CanvasRenderingContext2D : [Attachment 30452] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nate Chapin
<japhet at google.com>'s request for review:
Bug 25858: Upstream V8 bindings for CanvasRenderingContext2D
https://bugs.webkit.org/show_bug.cgi?id=25858

Attachment 30452: patch
https://bugs.webkit.org/attachment.cgi?id=30452&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp

> +// Helper macro for converting v8 values into floats (expected by many of
the
> +// canvas functions).
> +#define TO_FLOAT(a) static_cast<float>((a)->NumberValue())

Can this be rewritten as an inline function instead?  It is best to
avoid macros whenever possible.

Can you use toFloat from V8Binding.h?


> +CALLBACK_FUNC_DECL(CanvasRenderingContext2DPutImageData)
...
> +    if (V8Proxy::IsWrapperOfType(args[0], V8ClassIndex::IMAGEDATA)) {
> +	   imageData =
V8Proxy::ToNativeObject<ImageData>(V8ClassIndex::IMAGEDATA, args[0]);
> +    }

style nit: no brackets around single lines