[webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 30465] gettextv3.patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 19 03:36:53 PDT 2009
Xan Lopez <xan.lopez at gmail.com> has asked for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415
Attachment 30465: gettextv3.patch
https://bugs.webkit.org/attachment.cgi?id=30465&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, I think I've fixed all issues raised in the last comment (most of them were
really special cases of the same bug: "Not taking into account being in the
first or last word/sentence"). I've also fixed the crashers, which were due to
not doing error checking properly in some cases.
LINE_{START,END} is still missing from the patch.
More information about the webkit-reviews
mailing list