[webkit-reviews] review requested: [Bug 25417] Skia CompositeCopy should be mapped to kSrc_Mode not kSrcOver_Mode. : [Attachment 30457] Adding layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 18 20:01:11 PDT 2009


Shinichiro Hamaji <hamaji at google.com> has asked  for review:
Bug 25417: Skia CompositeCopy should be mapped to kSrc_Mode not kSrcOver_Mode.
https://bugs.webkit.org/show_bug.cgi?id=25417

Attachment 30457: Adding layout test
https://bugs.webkit.org/attachment.cgi?id=30457&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at google.com>
Thanks for your description! Now I see what you meant.

I added tests for alpha=0 cases and add expected texts for these cases. I also
fixed style issues you pointed. Now the layout test generate HTML table on the
fly, some variables have better name, and JS style was fixed.


More information about the webkit-reviews mailing list