[webkit-reviews] review granted: [Bug 25832] Refactor JIT code-handle objects. : [Attachment 30428] Double Gah, removing accidentally committed example code written for review comments.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 25832: Refactor JIT code-handle objects.
https://bugs.webkit.org/show_bug.cgi?id=25832

Attachment 30428: Double Gah, removing accidentally committed example code
written for review comments.
https://bugs.webkit.org/attachment.cgi?id=30428&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   template<class AssemblerType_T>
> +	   template<class g>
>	   friend class AbstractMacroAssembler;

I don't think you meant to say "g" here.

> +	   void relinkCallerToTrampoline(CodeLocationLabel label)
> +	   {
> +	      
AssemblerType::patchMacroAssemblerCall(reinterpret_cast<intptr_t>(this->m_locat
ion), reinterpret_cast<void*>(label.getJumpDestination()));
> +	   }

This seems to be casting void* to void* using reinterpret_cast. Lets leave that
cast out.

> +#ifndef NDEBUG
> +	       , m_size (masm->m_assembler.size())
> +#endif

Stray space here after m_size.

r=me