[webkit-reviews] review denied: [Bug 25119] IME modifies the DOM before keydown : [Attachment 30435] Fire keydown event before inserting text into the DOM on IME input.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 25119: IME modifies the DOM before keydown
https://bugs.webkit.org/show_bug.cgi?id=25119

Attachment 30435: Fire keydown event before inserting text into the DOM on IME
input.
https://bugs.webkit.org/attachment.cgi?id=30435&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
A couple style nits:

 1427 void Editor::applyIMECommand(IMECommand* command) {

     IMECommand(const String& confirmedText)
 63	: text(confirmedText)
 64	, isConfirmationCommand(true) {}
(indent and {} should be on new lines)

No arg name needed:
 281	 void applyIMECommand(IMECommand* command);


 34 </body>
 35 </html>
036 \ No newline at end of file


     // If there's a key event, stow away the IME command to be processed in
 5717	  // EventHandler::keyEvent after the keydown has been fired.
 5718	  if (parameters && parameters->event)
 5719	      parameters->event->setIMECommand(command);
 5720	  else
 5721	      coreFrame->editor()->applyIMECommand(command);

Could go into a static function in the file instead of copy/paste.