[webkit-reviews] review granted: [Bug 25286] [Gtk] Various autotools build refactoring and fixes : [Attachment 30382] refactor cflags

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 17 12:26:38 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 25286: [Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Attachment 30382: refactor cflags
https://bugs.webkit.org/attachment.cgi?id=30382&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> +# JavaScriptCore
>  javascriptcore_cppflags += \
> -	-I$(srcdir)/JavaScriptCore \
>	-I$(srcdir)/JavaScriptCore/ForwardingHeaders \
>	-I$(srcdir)/JavaScriptCore/parser \
>	-I$(srcdir)/JavaScriptCore/wtf \
> @@ -169,34 +218,14 @@ libWebCore_la_SOURCES = \
>  

This is because that's not needed to build WebCore, right? I would mention it
in the JSC ChangeLog, instead of just describing the change.

In any case, it looks good to me, so r=me.


More information about the webkit-reviews mailing list