[webkit-reviews] review requested: [Bug 25822] DOM normalize does not remove empty text node between element nodes : [Attachment 30421] Patch with more thorough set of test cases

[bugzilla-daemon at webkit.org]

Kai Brüning <kai at granus.net> has asked	for review:
Bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822

Attachment 30421: Patch with more thorough set of test cases
https://bugs.webkit.org/attachment.cgi?id=30421&action=review

------- Additional Comments from Kai Brüning <kai at granus.net>
I extended the test case to (hopefully) test the full range of the normalize()
functionality. To express this, I renamed it to "normalize.html". The test
lives inside "dom", therefore I consider the term "normalize" well defined.
Please advice if a longer name is necessary.

Having these tests and after learning that document->textNodesMerged() does
adjust DOMRanges to the changed text nodes and nothing more, I changed the code
of Node::normalize() a little more to make it more concise and less historic.

Concerning rationale of the old code, I checked the ChangeLogs and found the
entry about the addition of the "single empty text node child" case. It is
indeed rather inexpressively, just stating the addition of this case.