[webkit-reviews] review granted: [Bug 25769] Fix accessibility warnings on GTK : [Attachment 30350] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 25769: Fix accessibility warnings on GTK
https://bugs.webkit.org/show_bug.cgi?id=25769

Attachment 30350: patch
https://bugs.webkit.org/attachment.cgi?id=30350&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  {
>      struct RoleEntry {
> +    public:
>	   String ariaRole;
>	   AccessibilityRole webcoreRole;
>      };

This change does not make sense. In a struct, everything is public by default
and this should have no effect. I have no idea why gcc is warning about this,
but I do not think this is the fix.

> Index: WebCore/page/AccessibilityTable.cpp
> ===================================================================
> --- WebCore/page/AccessibilityTable.cpp	(revision 43716)
> +++ WebCore/page/AccessibilityTable.cpp	(working copy)
> @@ -350,7 +350,7 @@ void AccessibilityTable::cells(Accessibi
>      }
>  }
>      
> -const unsigned AccessibilityTable::columnCount()
> +unsigned AccessibilityTable::columnCount()
>  {
>      if (!hasChildren())
>	   addChildren();
> @@ -358,7 +358,7 @@ const unsigned AccessibilityTable::colum
>      return m_columns.size();    
>  }
>      
> -const unsigned AccessibilityTable::rowCount()
> +unsigned AccessibilityTable::rowCount()
>  {
>      if (!hasChildren())
>	   addChildren();
> Index: WebCore/page/AccessibilityTable.h
> ===================================================================
> --- WebCore/page/AccessibilityTable.h (revision 43716)
> +++ WebCore/page/AccessibilityTable.h (working copy)
> @@ -63,8 +63,8 @@ public:
>      AccessibilityChildrenVector& columns();
>      AccessibilityChildrenVector& rows();
>      
> -    const unsigned columnCount();
> -    const unsigned rowCount();
> +    unsigned columnCount();
> +    unsigned rowCount();
>      
>      virtual String title() const;

These changes are good.

I'm saying r=me, but don't land that "public:" change -- it should have no
effect.