[webkit-reviews] review granted: [Bug 25834] Make ChromeClient only have pure virtuals : [Attachment 30411] Make recent additions pure virtual again

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 25834: Make ChromeClient only have pure virtuals
https://bugs.webkit.org/show_bug.cgi?id=25834

Attachment 30411: Make recent additions pure virtual again
https://bugs.webkit.org/attachment.cgi?id=30411&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   virtual void scrollRectIntoView(const IntRect&, const ScrollView*)
const {} // Platforms other than Mac can implement this if it ever becomes
necessary for them to do so.
> +	   virtual void scrollRectIntoView(const IntRect&, const ScrollView*)
const = 0; // Platforms other than Mac can implement this if it ever becomes
necessary for them to do so.

I don't think the comment makes sense any more if this is a pure virtual.

This change seems OK. This is the reason I used pure virtuals in the first
place, but I'm not entirely sure either way whether this is a good thing or
not.

r=me