[webkit-reviews] review denied: [Bug 15597] [GTK] Text not discernable when using a dark Gtk+ style : [Attachment 30178] This fixes the whole problem

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 15597: [GTK] Text not discernable when using a dark Gtk+ style
https://bugs.webkit.org/show_bug.cgi?id=15597

Attachment 30178: This fixes the whole problem
https://bugs.webkit.org/attachment.cgi?id=30178&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
This patch requires a ChangeLog. Please see
http://webkit.org/coding/contributing.html for more info.

> --- RenderThemeGtk.cppp	2009-05-11 12:27:40.523120385 +0300
> +++ RenderThemeGtk.cpp	2009-05-11 12:27:27.969801589 +0300

Please do a diff in Webkit/ instead of WebCore/platform/gtk next time.

> @@ -272,6 +272,7 @@ void RenderThemeGtk::adjustButtonStyle(C
>	   style->resetBorder();
>	   style->setHeight(Length(Auto));
>	   style->setWhiteSpace(PRE);
> +	   style->setColor(gtkTreeView()->style->text[GTK_STATE_NORMAL]);
>	   setButtonPadding(style);
>      } else {
>	   // FIXME: This should not be hard-coded.
> @@ -306,6 +307,8 @@ void RenderThemeGtk::adjustTextFieldStyl
>      style->resetPadding();
>      style->setHeight(Length(Auto));
>      style->setWhiteSpace(PRE);
> +    style->setColor(gtkEntry()->style->text[GTK_STATE_NORMAL]);
> +    style->setBackgroundColor(gtkEntry()->style->base[GTK_STATE_NORMAL]);
>      adjustMozStyle(style, MOZ_GTK_ENTRY);
>  }

As I said in comment #8, we also need to accomodate for on-the-fly desktop
theme changes. 

I'm going to say r- until the issues I raised above gets resolved.