[webkit-reviews] review denied: [Bug 25263] WebKit GTK with libsoup won't recognize proxies : [Attachment 29611] to enable proxy-resolver feature in libsoup-gnome

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 15 17:15:51 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has denied Wang Lu <coolwanglu at gmail.com>'s
request for review:
Bug 25263: WebKit GTK with libsoup won't recognize proxies
https://bugs.webkit.org/show_bug.cgi?id=25263

Attachment 29611: to enable proxy-resolver feature in libsoup-gnome
https://bugs.webkit.org/attachment.cgi?id=29611&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
(In reply to comment #3)
> Created an attachment (id=29611) [review]
> to enable proxy-resolver feature in libsoup-gnome
> 
> Detect libsoup-gnome, and use it instead of libsoup, if exists.
> If libsoup-gnome exists, enable SOUP_TYPE_GNOME_FEATURES_2_26 when creating a

> new soup session

Since libsoup-gnome is not a hard-dependency, this feature should be
configurable at configure time and should be disabled by default. I would
suggest adding --with-gnome or --with-libsoup-gnome in configure.ac for this.

I'm going to say r- for now until have this feature configurable.


More information about the webkit-reviews mailing list