[webkit-reviews] review denied: [Bug 25806] gmtime_s and localtime_s are Microsoft extensions that don't exist in MSVC < 2005 : [Attachment 30372] Clean proper standard-compliant patch with a proper clean ChangeLog entry

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 25806: gmtime_s and localtime_s are Microsoft extensions that don't exist
in MSVC < 2005
https://bugs.webkit.org/show_bug.cgi?id=25806

Attachment 30372: Clean proper standard-compliant patch with a proper clean
ChangeLog entry
https://bugs.webkit.org/attachment.cgi?id=30372&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The ChangeLog entry has tabs in it, and lacks an email address.  As best I can
make out, the patch doesn’t do what the ChangeLog describes either.  It uses
localtime_s on older versions of MSVC, and uses localtime on newer versions. 
That doesn’t fit with the ChangeLog saying that localtime_s doesn’t exist on
older versions.