[webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 30370] gettextv2.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 15 01:22:55 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 30370: gettextv2.patch
https://bugs.webkit.org/attachment.cgi?id=30370&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, I *think* this now works as it should, but please review it carefully :)

I have removed the LINE_{START,END} implementation, since it was completely
wrong. I'll try to figure out how to get the visual line break information out
of WebKit now to do this.


More information about the webkit-reviews mailing list