[webkit-reviews] review denied: [Bug 25807] #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h : [Attachment 30357] patch that ifdefs properly the codes for windows platforms

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 25807: #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h
https://bugs.webkit.org/show_bug.cgi?id=25807

Attachment 30357: patch that ifdefs properly the codes for windows platforms
https://bugs.webkit.org/attachment.cgi?id=30357&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
No, that is way too ugly this way. Please let us go back to the problem and
then talk about solutions.

So your problem is:
   - Some VK_ are already there

My questions:
   - Why do you have a define for WIN_CE? There is no Gtk+ port to Windows CE?!


Proposed change:
   - Make the change with one #if !PLATFORM(GTK) block instead of squattering
that ugly thing all around. Alternatively create a cleaned
KeyboardCodesGtkWin32.h and include that from KeyEventGtk.cpp