[webkit-reviews] review denied: [Bug 25807] #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h : [Attachment 30357] patch that ifdefs properly the codes for windows platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 20:24:16 PDT 2009

Holger Freyther <zecke at selfish.org> has denied Fridrich Strba
<fridrich.strba at bluewin.ch>'s request for review:
Bug 25807: #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h

Attachment 30357: patch that ifdefs properly the codes for windows platforms

------- Additional Comments from Holger Freyther <zecke at selfish.org>
No, that is way too ugly this way. Please let us go back to the problem and
then talk about solutions.

So your problem is:
   - Some VK_ are already there

My questions:
   - Why do you have a define for WIN_CE? There is no Gtk+ port to Windows CE?!

Proposed change:
   - Make the change with one #if !PLATFORM(GTK) block instead of squattering
that ugly thing all around. Alternatively create a cleaned
KeyboardCodesGtkWin32.h and include that from KeyEventGtk.cpp

More information about the webkit-reviews mailing list